Fix tooltipped grouped buttons borders#9482
Merged
Merged
Conversation
This reverts commit 2eba4bb.
fregante
commented
May 16, 2026
| import {upperCaseFirst} from '../github-helpers/index.js'; | ||
|
|
||
| function getAjaxContainer(): Element | undefined { | ||
| return lastElementOptional('#js-repo-pjax-container, #js-pjax-container, #repo-content-turbo-frame, #repo-content-pjax-container'); |
Member
Author
There was a problem hiding this comment.
In my first attempt I added the tool-tip to the closest known ajax container (which is cleared on navigation) however somehow the tooltips did not show up on hover 🤷♂️
fregante
commented
May 16, 2026
| } | ||
|
|
||
| element.after(createTooltipFor(element, content)); | ||
| element.append(createTooltipFor(element, content)); |
Member
Author
There was a problem hiding this comment.
Interestingly, it does show when placed inside. This is the resulting DOM
Member
Author
|
I told myself "make no mistakes" |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9451 (comment)
Test URLs
Here and https://github.com/pyca/cryptography/releases
Screenshot