Skip to content

closing-remarks - Restore in PR header#9492

Merged
fregante merged 1 commit into
mainfrom
closing-remarks-header
May 18, 2026
Merged

closing-remarks - Restore in PR header#9492
fregante merged 1 commit into
mainfrom
closing-remarks-header

Conversation

@fregante

Copy link
Copy Markdown
Member

Test URLs

#9256

Screenshot

ours

This new style matches the native one appearing in issues, including the hover state:

native

@github-actions github-actions Bot added the bug label May 17, 2026

// PRs have a regular and a sticky header
observe('#partial-discussion-header relative-time', addExistingTagLinkToHeader.bind(undefined, tagName, tagUrl), {
observe('[class*="PullRequestHeaderSummary"] relative-time', addTagToHeader.bind(undefined, tagName, tagUrl), {

@fregante fregante May 17, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if I checked the mobile version as well.

  • check before merge

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does work:

Screenshot 13

and it adds more work to:

@fregante fregante merged commit 6f741e2 into main May 18, 2026
13 checks passed
@SunsetTechuila SunsetTechuila deleted the closing-remarks-header branch May 18, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

closing-remarks missing from header

1 participant