Skip to content

cross-deleted-pr-branches - Restore feature#9495

Merged
fregante merged 5 commits into
mainfrom
cross-deleted-pr-branches
May 19, 2026
Merged

cross-deleted-pr-branches - Restore feature#9495
fregante merged 5 commits into
mainfrom
cross-deleted-pr-branches

Conversation

@fregante

@fregante fregante commented May 17, 2026

Copy link
Copy Markdown
Member

@github-actions github-actions Bot added the bug label May 17, 2026
@@ -1,5 +1,7 @@
.commit-ref[title$='has been deleted'],
.commit-ref[title$='has been deleted'] * {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think GitHub used to have this title, but not anymore.

Comment on lines -33 to -37
if (element.classList.contains('head-ref')) {
$('a', element).href = repoRootUrl!;
} else {
wrap(element, <a href={repoRootUrl} />);
}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature used to linkify the deleted branches or point them to the repo root. I think it's unnecessary.

- ✏️ deleted (from fork): https://github.com/refined-github/sandbox/pull/149
- 🔗 deleted and restored: https://github.com/refined-github/sandbox/pull/147
- 🔗 deleted and restored (on fork): https://github.com/refined-github/sandbox/pull/150
- 🔗 forks that are deleted before deleting the branch are not detectable

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted forks used to be detectable, I think. Not anymore

Comment thread eslint-suppressions.json
},
"source/features/cross-deleted-pr-branches.tsx": {
"refined-github/no-optional-chaining": {
"count": 1

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly why suppressions work: you just fix them naturally when working on code (that might be broken in the first place)

@fregante fregante merged commit cf29bf8 into main May 19, 2026
10 checks passed
@fregante fregante deleted the cross-deleted-pr-branches branch May 19, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

cross-deleted-pr-branches broken

1 participant