quick-resolve-conflicts - New feature name#9580
Merged
Merged
Conversation
unwrap-unnecessary-dropdowns - Drop notifications supportquick-resolve-conflicts - New feature name
fregante
commented
May 23, 2026
| "faster-pr-diff-options": "one-click-diff-options", | ||
| "hide-useless-comments": "hide-low-quality-comments", | ||
| "no-useless-split-diff-view": "no-unnecessary-split-diff-view", | ||
| "unwrap-useless-dropdowns": "unwrap-unnecessary-dropdowns", |
Member
Author
There was a problem hiding this comment.
Since this part of the feature was introduced 2 weeks ago (#9367) I'm not gonna consider it a rename.
Once notifications-ui is created, we can keep that as a rename of unwrap-unnecessary-dropdowns. I have to remove it now because that feature doesn't exist yet.
Member
Author
There was a problem hiding this comment.
I updated the PR to avoid conflicts and added the rename there:
Member
Author
|
Any thoughts on the name? |
Contributor
|
The name is good, and so is the PR |
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unwrap-unnecessary-dropdownsbroken on notifications #9202This should be a dedicated feature. All of this code was deleted in #9368 anyway.
Given the complexity of "unwrapping" nowadays I wonder if the feature should just be renamed to
quick-resolve-conflictsto match the remaining code. The feature for example contained part ofrerun-workflowfor example, but that is now a standalone feature.Updated screenshot