Conversation
fregante
commented
May 25, 2026
| } | ||
|
|
||
| // 404 pages should only run 404-only features | ||
| if (pageDetect.is404() && !include?.includes(pageDetect.is404) && !asLongAs?.includes(pageDetect.is404)) { |
Member
Author
There was a problem hiding this comment.
So of course this will cause features to run on valid-looking URLs and failing. Surprisingly the /no-user page has no console errors and /user/no-repo only has a single console error, which... you know, it's kind of obvious since it is a 404 page
We can patch up these errors as they come up, if deemed necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test URLs
https://github.com/fregante/no-repo-here
https://github.com/no-user-here
Before
After