open-all-conversations - Ensure it's always there#9610
Merged
Conversation
fregante
commented
May 25, 2026
| ] as const; | ||
|
|
||
| async function hasMoreThanOneConversation(): Promise<boolean> { | ||
| return Boolean(await elementReady(multipleConversationsSelector, {waitForChildren: false})); |
Member
Author
There was a problem hiding this comment.
This doesn't work, so we drop it, easy.
Particularly, the code is not compatible with ajaxed views that update dynamically and may or may not have any issues.
Note that GitHub also shows a useless "select all issues" checkbox for the same reason:
It's less refined, but I'll take less refined over not working any day.
Member
Author
|
This is another component that would benefit from being dynamic (svelte) because its status could be:
and this just depends on the content/state of the list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open-all-conversationssometimes missing #9377open-all-conversations- Fix multiple conversations detection #9506Test URLs
https://github.com/refined-github/refined-github/issues?q=is%3Apr%20is%3Aopen%20sort%3Acreated-asc
Screenshot