Skip to content

Improve clickability of review type picker#9611

Merged
fregante merged 6 commits into
mainfrom
hover
May 26, 2026
Merged

Improve clickability of review type picker#9611
fregante merged 6 commits into
mainfrom
hover

Conversation

@fregante

Copy link
Copy Markdown
Member

Comment thread source/refined-github.css
/* width: auto; */
flex-grow: 1;
}
label[data-component='FormControl.Label']:not([data-control-disabled]) {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignores the disabled ones:

Image

Comment thread source/refined-github.css Outdated
position: relative;
&:hover::before {
content: '';
background-color: #fff2;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a transparent hover style? This is an overlay so it must be translucent. If it doesn't exist, I'll use rgba(var(blah blah, fuchsia), 5%)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway I suggest trying this CSS for a while to make sure we nail the style. I feel this is already ok since it matches the toolbar button hover for example, but maybe there's a similarly-large component elsewhere.

hover 2

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duhhh it's right here!! I'll copy this

hover 3

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied background and border-radius from that component

Screenshot 23 Screenshot 24

Comment thread source/refined-github.css Outdated
Comment thread source/refined-github.css
&:hover::before {
content: '';
position: absolute;
z-index: -1;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually placed it under for an extremely small improvement:
before/after
Image

Image

@fregante fregante May 26, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially only visible when the var will fail

Image Screenshot 2

@fregante fregante enabled auto-merge (squash) May 26, 2026 17:16
@fregante fregante merged commit d5a23d3 into main May 26, 2026
12 checks passed
@fregante fregante deleted the hover branch May 26, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Improve clickability of review type (approve, comment, request changes)

2 participants