Skip to content

Improve comment header wrapping on mobile /2#9700

Merged
fregante merged 5 commits into
mainfrom
issue-comment-header
Jun 7, 2026
Merged

Improve comment header wrapping on mobile /2#9700
fregante merged 5 commits into
mainfrom
issue-comment-header

Conversation

@fregante

@fregante fregante commented Jun 5, 2026

Copy link
Copy Markdown
Member

@fregante

fregante commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@fregante fregante marked this pull request as ready for review June 5, 2026 05:34
@fregante

fregante commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

I really just need to use flex-wrap or display:contents in there, this is just not possible.

#8409

Screenshot 2

max-content on the left side seems natural, but the avatar is outside that flexbox, so it will keep max-content and wrap below the avatar.

wrap

@fregante

fregante commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

mfw we test more than native GitHub:

Screenshot 4

@fregante

fregante commented Jun 6, 2026

Copy link
Copy Markdown
Member Author
Screenshot 5 Screenshot 6 Screenshot 7 Screenshot 8

@fregante

fregante commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

The amount of code required to deal with all their crappy components is already too much. If one more report comes in I'll drop the code altogether, leaving the most minimal bug fix to avoid this junk without caring about making it look perfect

@fregante fregante merged commit 31f94ba into main Jun 7, 2026
13 checks passed
@fregante fregante deleted the issue-comment-header branch June 7, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant