Place SHELLSPEC_INFILE file under the temporary directory#361
Open
thanegill wants to merge 1 commit into
Open
Conversation
When --random is used, the runner writes the shuffled spec list to $SHELLSPEC_INFILE, which defaulted to the relative path "file". That left a stray "file" in the working/project directory, truncating any existing ./file, and — unlike every other internal scratch file, which lives under $SHELLSPEC_TMPBASE and is removed by cleanup() — it was never cleaned up. Set SHELLSPEC_INFILE to "$SHELLSPEC_TMPBASE/.shellspec-infile" alongside the sibling temporary files so it is isolated, never clobbers a user's file, and is removed on exit. Add a regression spec that runs the binary with --random and asserts no stray file is left in the working directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--randomis used, the runner writes the shuffled spec list to$SHELLSPEC_INFILE, which defaults to the relative pathfile. This drops a stray file namedfileinto the working/project directory, silently overwrites any existing./file, and is never cleaned up, unlike every other internal scratch file.Reproduce this issue with:
Along with this fix:
spec/random_no_stray_file_spec.sh: a regression spec parameterized over both--random specfilesand--random examples(the two paths through the write). It runs the binary in an isolated project and asserts the working directory gains no unexpected entries. Because the self-test suite runs under--sandbox, which makesPATHread-only, the nested binary is launched via a freshsh -cwithPATHrestored from$SHELLSPEC_POSIX_PATH.CHANGELOG.mdentry under[Unreleased].