Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(connectors): remove non-TSDoc inline comments
  • Loading branch information
waleedlatif1 committed Jun 2, 2026
commit 5c9a49e787fa4c4110aaa6edbee71ef0c1d01d23
4 changes: 0 additions & 4 deletions apps/sim/connectors/fathom/fathom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -489,10 +489,6 @@ export const fathomConnector: ConnectorConfig = {
return hydrated
}

// No cached header (defensive — `listDocuments` always caches one in the
// shared sync context before `getDocument` runs in the same run). Omit the
// hash so the engine reuses the authoritative stub `contentHash` instead of
// persisting a divergent value that would loop as a perpetual "update".
return omit(hydrated, ['contentHash']) as ExternalDocument
Comment thread
waleedlatif1 marked this conversation as resolved.
Outdated
} catch (error) {
logger.warn('Failed to get Fathom meeting', {
Expand Down
4 changes: 0 additions & 4 deletions apps/sim/connectors/gitlab/gitlab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,6 @@ export const gitlabConnector: ConnectorConfig = {
throw new Error('Project is required')
}

// Resolve the project path once per sync for building source URLs.
let projectPath = (syncContext?.projectPath as string) ?? ''
if (!projectPath && syncContext) {
const projectResponse = await fetchProject(apiBase, encodedProject, accessToken)
Expand All @@ -410,7 +409,6 @@ export const gitlabConnector: ConnectorConfig = {
const state = decodeCursor(cursor, initialPhase)

if (state.phase === 'wiki' && wantsWiki) {
// Wikis have no pagination; list every page (with content) in one pass.
const url = `${apiBase}/projects/${encodedProject}/wikis?with_content=1`
logger.info('Listing GitLab wiki pages', { host, project: encodedProject })

Expand Down Expand Up @@ -446,7 +444,6 @@ export const gitlabConnector: ConnectorConfig = {
return { documents: capped, hasMore: false }
}

// Advance to the issues phase.
return {
documents: capped,
nextCursor: encodeCursor({ phase: 'issues', issuePage: 1 }),
Expand Down Expand Up @@ -624,7 +621,6 @@ export const gitlabConnector: ConnectorConfig = {

const projectRecord = (await response.json()) as GitLabProject

// When syncing wikis, confirm the wiki feature is enabled on the project.
if (choice === 'wiki' || choice === 'both') {
const accessLevel = projectRecord.wiki_access_level
const enabled =
Expand Down
4 changes: 1 addition & 3 deletions apps/sim/connectors/monday/monday.ts
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,6 @@ export const mondayConnector: ConnectorConfig = {
const fallbackBoard = { id: board.id, name: board.name }

const prevFetched = (syncContext?.totalDocsFetched as number) ?? 0
// monday charges query complexity per returned item, so when a maxItems cap
// leaves fewer than a full page remaining, request only what's needed.
const pageLimit =
maxItems > 0
? Math.min(ITEMS_PAGE_SIZE, Math.max(1, maxItems - prevFetched))
Expand Down Expand Up @@ -449,7 +447,7 @@ export const mondayConnector: ConnectorConfig = {
let hasMore = false

if (hitLimit) {
// Stop syncing — item cap reached
nextCursor = undefined
} else if (nextItemsCursor) {
nextCursor = encodeCursor({ boardIndex: state.boardIndex, itemsCursor: nextItemsCursor })
hasMore = true
Expand Down
3 changes: 0 additions & 3 deletions apps/sim/connectors/rootly/rootly.ts
Original file line number Diff line number Diff line change
Expand Up @@ -421,9 +421,6 @@ export const rootlyConnector: ConnectorConfig = {
if (status) queryParams.set('filter[status]', status)
if (severity) queryParams.set('filter[severity]', severity)

// Incremental sync: Rootly supports filtering by update time and sorting by it,
// so the engine only re-reads incidents changed since the last successful sync.
// Sort most-recently-updated first so the freshest changes page in first.
if (lastSyncAt) {
queryParams.set('filter[updated_at][gt]', lastSyncAt.toISOString())
queryParams.set('sort', '-updated_at')
Expand Down
Loading