new-installer: Support showing progress in terminal title#52465
new-installer: Support showing progress in terminal title#52465michaelkuhn wants to merge 1 commit into
Conversation
f8bf151 to
5b920e2
Compare
|
Should the terminal title also update when it's finished? Currently it seems to be in the "in progress" branch only. |
5b920e2 to
7006f44
Compare
I could add a separate title for this, but I guess it would only show "Spack: Done! ✨" for a split second before the terminal title is overwritten by the shell anyway. |
On macOS it looks like this after it's finished |
7006f44 to
9903971
Compare
Ah, looks like macOS does not set a terminal title then. I added some code to explicitly clear the title after we're finished and pushed an update. Let me know if that works for you. |
9903971 to
296e606
Compare
|
OK, I think this needs a little bit of improvement still. The I think it's more natural if it goes in |
The new installer has nice inline progress reporting, but when switching away from a tab, there is currently no way to keep track of progress. This adds support for showing progress in the terminal title, similar to the old installer. Signed-off-by: Michael Kuhn <michael.kuhn@ovgu.de>
296e606 to
0b1b260
Compare
Got it, I've pushed a new version. We now update the terminal title in three places: When changing the number of jobs, when updating the state and when finalizing (to clear it). |
|
@haampie Ping? 🙂 |
The new installer has nice inline progress reporting, but when switching away from a tab, there is currently no way to keep track of progress. This adds support for showing progress in the terminal title, similar to the old installer.