Skip to content

Respect no_cache for git sources#52501

Open
ryan-charette wants to merge 1 commit into
spack:developfrom
ryan-charette:fix-git-no-cache
Open

Respect no_cache for git sources#52501
ryan-charette wants to merge 1 commit into
spack:developfrom
ryan-charette:fix-git-no-cache

Conversation

@ryan-charette
Copy link
Copy Markdown

Fixes #52349

Summary

This fixes git source fetching so no_cache=True is honored when a package changes git fetch options such as submodules=True.

Changes

  • Preserve explicit no_cache=True when constructing git fetchers for commit-based versions
  • Re-fetch an existing expanded git stage when caching is disabled instead of reusing stale staged sources
  • Include submodule-related git fetch options in the source-cache key so cached archives with different submodule behavior do not collide
  • Add regression tests for stale git stages, commit variants with no_cache=True, and submodule-sensitive cache keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no_cache=True does not override presence of existing git cache

1 participant