Skip to content

Allow tests to tolerate new default column encodings in Redshift#114

Merged
jklukas merged 1 commit into
masterfrom
fix-tests
Apr 27, 2017
Merged

Allow tests to tolerate new default column encodings in Redshift#114
jklukas merged 1 commit into
masterfrom
fix-tests

Conversation

@jklukas

@jklukas jklukas commented Apr 26, 2017

Copy link
Copy Markdown
Member

In order to get a new release out the door, we need to get tests passing.

Looks like Redshift changed the behavior for default encodings. Previously, all columns were RAW by default. Now, encoding is chosen per column type as discussed in http://docs.aws.amazon.com/redshift/latest/dg/c_Compression_encodings.html

I'll be pushing changes to this branch as I work.

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst

@jklukas jklukas changed the title WIP: Fix tests for new encoding defaults Allow tests to tolerate new default column encodings in Redshift Apr 26, 2017
@jklukas

jklukas commented Apr 26, 2017

Copy link
Copy Markdown
Member Author

Tests are now passing locally and I'm removing the WIP label. This is ready for review.

@jklukas jklukas requested a review from graingert April 26, 2017 20:34
@jklukas

jklukas commented Apr 26, 2017

Copy link
Copy Markdown
Member Author

cc @ericness who was interested in getting recent changes released, which will rely on this.

@jklukas jklukas merged commit fb4d146 into master Apr 27, 2017
@jklukas jklukas deleted the fix-tests branch April 27, 2017 14:08
@graingert

Copy link
Copy Markdown
Member

@jklukas what's your PyPI username?

@jklukas

jklukas commented Apr 27, 2017

Copy link
Copy Markdown
Member Author

I'm Jeff.Klukas on pypi.

@jklukas

jklukas commented May 4, 2017

Copy link
Copy Markdown
Member Author

@graingert - Have you gotten a chance to add me on PyPI? It would be good for me to have the chance to do a release and make sure I understand the steps. I'd plan to document those as well as I go through.

@graingert

Copy link
Copy Markdown
Member

@jklukas I mostly just do

# ~/.pypirc
[zest.releaser]
create-wheels = yes
vim HISTORY.rst
python3.6 -m venv ~/.virtualenvs/dist
workon dist
pip install -U pip setuptools wheel
pip install -U tox zest.releaser
fullrelease  # follow prompts, use semver ish with versions.

@jklukas

jklukas commented May 4, 2017

Copy link
Copy Markdown
Member Author

I just performed a release. Releaser is amazing. Version 0.6.0 is on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants