Avoid manipulating search path in table metadata fetch#147
Merged
jklukas merged 4 commits intoDec 11, 2018
Conversation
Contributor
Author
|
Hey! I was just wondering about next steps for merging this in. I'd be happy to add an entry to CHANGES. Not sure if new tests/docs are relevant here. We're also bumping into the issue solved by #105, so I'd be happy to update that one to reflect the changes here. |
4 tasks
jklukas
reviewed
Dec 10, 2018
jklukas
left a comment
Member
There was a problem hiding this comment.
Passing integration tests, so this looks great! All we need is a line in CHANGES.rst that describes the change in behavior and links to this PR, and I'll go ahead and merge.
Contributor
Author
|
Does that look okay? |
Co-Authored-By: cwegrzyn <chris.wegrzyn@gmail.com>
Contributor
Author
|
Oops, thanks! Committed |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've run into some issues with transactions and the way that
_get_all_column_infomanipulates the search path. The search path manipulation only appears to be necessary becausepg_table_defis used-- butpg_table_defis a pretty simple view that we can integrate into the query, minus its pesky search path filter.For reference,
pg_table_defis defined on Redshift as follows:pg_table_is_visibleis the bit that limits to tables in the search path.Todos