Skip to content

Feature/header#156

Merged
jklukas merged 6 commits into
sqlalchemy-redshift:masterfrom
MoneyLion:feature/header
Dec 10, 2018
Merged

Feature/header#156
jklukas merged 6 commits into
sqlalchemy-redshift:masterfrom
MoneyLion:feature/header

Conversation

@andymeierdev

@andymeierdev andymeierdev commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

Change Summary

  • add header option
UNLOAD ('select-statement')
TO 's3://object-path/name-prefix'
authorization
[ option [ ... ] ]

where option is

{ MANIFEST [ VERBOSE ] 
| HEADER                                                      <<<<<
| DELIMITER [ AS ] 'delimiter-char' 
| FIXEDWIDTH [ AS ] 'fixedwidth-spec' }  
| ENCRYPTED
| BZIP2  
| GZIP     
| ADDQUOTES 
| NULL [ AS ] 'null-string'
| ESCAPE
| ALLOWOVERWRITE
| PARALLEL [ { ON | TRUE } | { OFF | FALSE } ]
| MAXFILESIZE [AS] max-size [ MB | GB ] ]
| REGION [AS] 'aws-region'
  • fix unload_location parameter

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst

@jklukas jklukas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure here looks good. Left a few comments on things to fix up.

If you address those fixes and add an entry to the CHANGES file, this looks good to me.

cc @graingert

Comment thread sqlalchemy_redshift/commands.py Outdated
Comment thread .gitignore Outdated
Comment thread sqlalchemy_redshift/commands.py Outdated
@andymeierdev

Copy link
Copy Markdown
Contributor Author

@jklukas thanks for the quick review 👍

Updated the PR based on your comments. Let me know if you would like any other changes.

Comment thread CHANGES.rst
@jklukas

jklukas commented Nov 29, 2018

Copy link
Copy Markdown
Member

If you accept the CHANGES change, I'll go ahead and merge this.

jklukas and others added 2 commits December 8, 2018 10:56
Co-Authored-By: ameier38 <ameier38@gmail.com>
@jklukas jklukas merged commit 2b7ca95 into sqlalchemy-redshift:master Dec 10, 2018
@jklukas

jklukas commented Dec 11, 2018

Copy link
Copy Markdown
Member

@andymeierdev andymeierdev deleted the feature/header branch December 12, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants