Feature/header#156
Merged
Merged
Conversation
jklukas
reviewed
Nov 13, 2018
jklukas
left a comment
Member
There was a problem hiding this comment.
The structure here looks good. Left a few comments on things to fix up.
If you address those fixes and add an entry to the CHANGES file, this looks good to me.
cc @graingert
…rst; remove IDEs from .gitignore
Contributor
Author
|
@jklukas thanks for the quick review 👍 Updated the PR based on your comments. Let me know if you would like any other changes. |
jklukas
approved these changes
Nov 29, 2018
jklukas
approved these changes
Nov 29, 2018
Member
|
If you accept the CHANGES change, I'll go ahead and merge this. |
Co-Authored-By: ameier38 <ameier38@gmail.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
headeroptionunload_locationparameterTodos