Skip to content

Support HLLSKETCH Redshift datatypes#246

Merged
Brooke-white merged 3 commits into
sqlalchemy-redshift:mainfrom
Steff94190:add_hll_type
Mar 4, 2022
Merged

Support HLLSKETCH Redshift datatypes#246
Brooke-white merged 3 commits into
sqlalchemy-redshift:mainfrom
Steff94190:add_hll_type

Conversation

@Steff94190

@Steff94190 Steff94190 commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

Adds support for Redshift HLLSKETCH datatypes. Fixes #245.

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst

@Steff94190 Steff94190 changed the title Support GEOMETRY, SUPER Redshift datatypes Support HLLSKETCH Redshift datatypes Mar 4, 2022
@Brooke-white Brooke-white self-requested a review March 4, 2022 17:20
@Brooke-white

Copy link
Copy Markdown
Contributor

Hey @Steff94190, This looks good to me. I've kicked off our CI. Thank you for updating the changelog and adding the tests! :)

@Brooke-white Brooke-white left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Steff94190 , LGTM :)

@Brooke-white Brooke-white merged commit 6d88b44 into sqlalchemy-redshift:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HLLSKETCH

3 participants