Fix redshift_connector dialect column encoding#255
Merged
Brooke-white merged 2 commits intoJul 18, 2022
Conversation
jklukas
approved these changes
Jul 13, 2022
jklukas
left a comment
Member
There was a problem hiding this comment.
Changes look good. Thanks for the full description of context for the change.
jwaterworth
pushed a commit
to jwaterworth/sqlalchemy-redshift
that referenced
this pull request
Aug 5, 2022
* fix(dialect): set description_encoding based on driver version * Update CHANGES.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #254
redshift_connector's release 2.0.908 changes the DBAPI method
Cursor.descriptionto return column names asstrrather thanbytes.This breaks the sqlalchemy-redshift dialect for redshift_connector as it sets
description_encoding="uses_encoding"here. This attribute is used to determine if a sqlalchemy method for converting the column names frombytestostrshould be called.Since redshift_connector returns a
str, we shouldn't setdescription_encoding="uses_encoding"unless using an older version (<= 2.0.908).A similar fix was made for the pg8000 sqlalchemy dialect: sqlalchemy/sqlalchemy@b2f2bf1
Related issue aws/amazon-redshift-python-driver#116
Todos