Patch supports_statement_cache warning.#259
Merged
Brooke-white merged 2 commits intoDec 8, 2022
Merged
Conversation
Brooke-white
requested changes
Nov 9, 2022
Contributor
There was a problem hiding this comment.
overall looks good, let's apply this change to the redshift_connector dialect as well for consistency.
if you could add an entry to changes.rst for this PR I can go ahead and merge it
…y implementation looks into the class dictionary which is why the warning is still present even though flag is set on the Mixin base classes. The value is properly set into the base classes now.
a088238 to
7c0e80d
Compare
Contributor
Author
|
@Brooke-white just updated the changelog. |
supports_statement_cache warning.supports_statement_cache warning.
supports_statement_cache warning.supports_statement_cache warning.
Brooke-white
approved these changes
Nov 21, 2022
Contributor
Author
|
Thanks for adding the PR link. I completely missed it :( |
Brooke-white
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix SQLAlchemy
supports_statement_cachewarning.SQLAlchemy implementation looks into the class dictionary which is why the warning is still present even though flag is set on the Mixin base classes. The value is properly set into the base classes now.
This is why it's stated on their documentation:
Todos