Add all options to UnloadFromSelect, with SQLi protection#27
Conversation
There was a problem hiding this comment.
I updated this to match the same helper functions in test_unload_from_select
5d6e5c8 to
64f1fe4
Compare
There was a problem hiding this comment.
Constants should be named in all caps, and I'd prefer RE or REGEX to RX unless this is conforming to a standard I'm not aware of (CREDS_RE).
64f1fe4 to
2854c96
Compare
There was a problem hiding this comment.
Why check None specifically here rather than relying on the boolean interpretation of el.fixed_width? Would we want to omit this clause in the case of an empty list?
There was a problem hiding this comment.
None is the default? I think I want it to break accordingly if someone passes an empty list or False. I'm not tied to this.
There was a problem hiding this comment.
okay I'm updating fixed_width, note null and delimiter must be is not None or we can't support the empty string null or delimiter value
2854c96 to
3a684a3
Compare
|
This is looking much nicer for the refactor. I like this PR. |
4afa5ae to
d6693a6
Compare
validate credentials before format Better exception text prevent an empty FIXEDWITH string as that's an error.
d6693a6 to
cdcd103
Compare
…lect-with-SQLi-protection Add all options to UnloadFromSelect, with SQLi protection
…ons-to-UnloadFromSelect-with-SQLi-protection Add all options to UnloadFromSelect, with SQLi protection
No description provided.