copy should have default format=None and fix statupdate#53
Merged
Conversation
Member
|
Nice spot. Can you update the changelog? |
Contributor
Author
|
Done :) |
Member
|
@solackerman can you match the style of the rest of the changelog? |
Member
|
Eg: 0.3.1 (unreleased)
------------------
- Fix breakages to CopyCommand introduced in 0.3.0:
Thanks `solackerman <https://github.com/solackerman>`_.
(`Issue #53 <https://github.com/graingert/redshift_sqlalchemy/pull/53>`_)
- When `format` is omitted, no `FORMAT AS ...` is appended to the query. This
makes the default the same as a normal redshift query.
- fix STATUPDATE as a COPY parameter
|
Contributor
Author
|
done |
Member
|
@solackerman can you squash all your commits into one please? |
Contributor
Author
|
done |
graingert
added a commit
that referenced
this pull request
Oct 7, 2015
copy should have default format=None and fix statupdate
Member
|
@solackerman Awesome, thank-you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 things are being done in this PR:
formatis omitted, noFORMAT AS ...is appended to the query. This makes the default the same as a normal redshift query