Refactor and add test cases for sql_table#305
Merged
Conversation
Contributor
|
@Racso-3141 now it is just the linting check that is failing. You can run the linter locally as per https://github.com/stackql/stackql/blob/main/docs/developer_guide.md#linting It may be that restoring the We can only thank you for your patience; some of this documentation needs to be brought togetther better. |
774738d to
70473b6
Compare
general-kroll-4-life
approved these changes
Oct 8, 2023
Contributor
general-kroll-4-life
left a comment
There was a problem hiding this comment.
No real need to rename the package, but let us be democratic.
Contributor
Author
|
Hello, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have refactored NewStandardSQLTable to use input parameter relationalColumns to intialize columns field of returned standardSQLTable. I add test cases for NewStandardSQLTable, GetColumns, and GetSymTab. Test Coverage 100%.
Closes #300
Closes #301