Add unit testing to package templatenamespace#309
Conversation
|
I am new to golang. Please review. |
|
@sanketmp the linting check is failing, all else seems ok. You can run the linter locally, as per the developer guide. |
@general-kroll-4-life it's showing me 404 page after clicking the link. Edit: Also I have committed the update. |
…sanketmp/stackql into add-templatenamespace-unit-test
|
@sanketmp sorry here is the correct reference: https://github.com/stackql/stackql/blob/main/docs/developer_guide.md#linting |
|
Hi @general-kroll-4-life I am getting this error. |
|
Don't expect that applies to test packages. Try it and see |
|
@general-kroll-4-life I have tried this with an underscore in the package name and it collapses the whole codefile. Also, it does not recognize the One more thing. I saw both Lint Workflow runs and neither of them have mentioned this issue/error. |
|
@sanketmp got the tests to work and linter to pass with a couple of changes. Here below is the output of Please let me know if you need anything further? |
|
Oh right, I hadn't thought of that. Thanks @general-kroll-4-life. |
general-kroll-4-life
left a comment
There was a problem hiding this comment.
@sanketmp good stuff thank you
|
Glad I could help🙌 |
|
great job @sanketmp ! can you make sure to give us a ⭐ at https://github.com/stackql/stackql, thanks again! |
|
⭐Starred. 🎉 Thank you @jeffreyaven it was a great experience. |
Description
Added unit testing for
internal/stackql/templatenamespacepackageType of change
Issues referenced.
Fixes #277
Evidence
Checklist:
Variations
Tech Debt