Skip to content

Added divide_poly function#1624

Draft
jmig5776 wants to merge 1 commit into
symengine:masterfrom
jmig5776:implement_div
Draft

Added divide_poly function#1624
jmig5776 wants to merge 1 commit into
symengine:masterfrom
jmig5776:implement_div

Conversation

@jmig5776
Copy link
Copy Markdown
Contributor

@jmig5776 jmig5776 commented Nov 9, 2019

This PR wil implement divide function for polynomial.
Current API looks like

void divide_poly(const RCP<const Basic> &dividend, const RCP<const Basic> &divisor,
            const Ptr<RCP<const UIntPolyFlint>> &quotient,
            const Ptr<RCP<const UIntPolyFlint>> &remainder)

CC @certik @isuruf

@isuruf-bot
Copy link
Copy Markdown

Hi,

I've run clang-format and found that the code needs formatting.
Here's a commit that fixes this. isuruf-bot@e0c285d

To use the commit you can do

curl -o format.diff https://github.com/isuruf-bot/symengine/commit/e0c285d386af024b1add4481fa30f7994236b790.diff
git apply format.diff

@jmig5776
Copy link
Copy Markdown
Contributor Author

jmig5776 commented Nov 9, 2019

@certik @isuruf Any suggestions for Input and Output API for this function?

@certik
Copy link
Copy Markdown
Contributor

certik commented Nov 9, 2019

I think the API is fine for now. As we start using this more, we can refine it.

@isuruf
Copy link
Copy Markdown
Member

isuruf commented Nov 9, 2019

There is divides_upoly at the moment which only give quotient. We can extend that API to give the remainder optionally.

@jmig5776
Copy link
Copy Markdown
Contributor Author

There is divides_upoly at the moment which only give quotient. We can extend that API to give the remainder optionally.

Yes I saw that but I think I should create this new function rather than trying to change or edit the existing function which has its own use case.

@isuruf isuruf marked this pull request as draft September 29, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants