Fix malformed inference form JSON returning 500#7509
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
|
✅ All contributors to this pull request have signed the TensorZero CLA. Thank you! |
Author
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
/api/tensorzero/inferenceso malformed JSON in thedataform field returns400 Bad Requestinstead of a generic500 Server error.Details
The route used native
JSON.parse(data)but only handled the customJSONParseErrortype. NativeJSON.parsethrowsSyntaxError, so malformed JSON fell through to the generic server-error response.This change parses
datain a dedicatedtry/catchand returns the existing parse-error response with status 400.Fixes #7508
Tests
npx --yes pnpm@10.33.0 exec vitest run app/routes/api/tensorzero/inference.test.tsnpx --yes pnpm@10.33.0 run formatnpx --yes pnpm@10.33.0 run lintnpx --yes pnpm@10.33.0 --filter=@tensorzero/tensorzero-node buildnpx --yes pnpm@10.33.0 run typecheck