Switch opentelemetry-otlp features to use aws-lc-rs over ring#7519
Open
Aaron1011 wants to merge 1 commit into
Open
Switch opentelemetry-otlp features to use aws-lc-rs over ring#7519Aaron1011 wants to merge 1 commit into
Aaron1011 wants to merge 1 commit into
Conversation
This will allow us to remove our 'ring' dependency in external projects, which will slightly speed up compilation time, and make us post-quantum compatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to remove our 'ring' dependency in external projects, which will slightly speed up compilation time, and make us post-quantum compatible
Note
Low Risk
Single Cargo feature swap for OTLP TLS with no application code changes; risk is limited to build-time crypto backend compatibility for OTLP gRPC connections.
Overview
The workspace
opentelemetry-otlpfeature set is updated so OTLP gRPC TLS usestls-aws-lcinstead oftls(ring-backed). Behavior should stay the same for OTLP export over TLS, while aligning with the workspace’s existingrustlsaws_lc_rscrypto stack and reducing reliance on ring in the dependency graph.Reviewed by Cursor Bugbot for commit 0d345e4. Configure here.