Try again to fix GCP Vertex batch tests#7521
Open
Aaron1011 wants to merge 1 commit into
Open
Conversation
I've bumped the max_tokens again (we're still seeing intermittent 'max_length' finish reasons), as well as disabled the 'tool_choice=none' test that interacts badly with Gemini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've bumped the max_tokens again (we're still seeing intermittent 'max_length' finish reasons), as well as disabled the 'tool_choice=none' test that interacts badly with Gemini
Note
Low Risk
Changes are limited to e2e fixtures and test skips; no production inference or provider runtime logic is modified.
Overview
Stabilizes GCP Vertex Gemini batch e2e by raising
max_tokenson thegcp-vertex-gemini-flashvariant from 200 → 400 in bothbasic_testfixture configs (file-based and config-in-db), aiming to cut intermittentmax_lengthfinish reasons.In
batch.rs, thetool_choice="none"tool-use checks are skipped whenmodel_provider_name == "gcp_vertex_gemini"(in two parallel test paths). Vertex can returnUNEXPECTED_TOOL_CALLwith empty content and nocandidatesTokenCount, which fails the existingoutput_tokens > 0assertion until finish-reason mapping and assertions are relaxed.Reviewed by Cursor Bugbot for commit cc59500. Configure here.