POAM related finding support, fixes #1120#1478
Merged
david-waltermire merged 7 commits intoOct 17, 2022
Merged
Conversation
added 3 commits
September 27, 2022 09:21
…hub.com/Compton-NIST/OSCAL into issue-1120-poam-related-finding-support
8 tasks
…to assessment common from assessment result metaschema.
Contributor
Author
|
Important note on this PR, since I realized I needed to adjust slightly: There is the addition of the related-findings assembly, but I also needed to add the findings assembly, similar to the observations and risks assemblies in the POAM. As a part of this, the assessment-result model contained the findings assembly, so I moved that to assessment-common to support both the poam and assessment-result models. |
Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
8 tasks
aj-stein-nist
added a commit
that referenced
this pull request
Oct 18, 2022
* Add related finding assembly. #1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
david-waltermire
pushed a commit
that referenced
this pull request
Oct 31, 2022
* Add related finding assembly. #1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jan 10, 2023
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Feb 6, 2023
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
aj-stein-nist
added a commit
to galtm/OSCAL
that referenced
this pull request
Sep 28, 2023
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
To match the pattern of POAM for handling observations and risks, a
related-findingsassembly was added.