Add missing $ in Linux build setup steps#1779
Merged
Merged
Conversation
The steps cannot be copied and pasted as-is because the `chown` command is missing a `$` for the `USER` variable for the group argument. This also adds quotation marks around the variables.
aj-stein-nist
approved these changes
May 3, 2023
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
Nice catch, thank you for your contribution, @kylelaker.
Contributor
|
Thanks again, apologies for not merging this sooner. |
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
The steps cannot be copied and pasted as-is because the `chown` command is missing a `$` for the `USER` variable for the group argument. This also adds quotation marks around the variables.
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
The steps cannot be copied and pasted as-is because the `chown` command is missing a `$` for the `USER` variable for the group argument. This also adds quotation marks around the variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
The steps cannot be copied and pasted as-is because the
chowncommandis missing a
$for theUSERvariable for the group argument. Thisalso adds quotation marks around the variables.
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.