Fix dependency issue in rexml module in Gemfile#482
Merged
robertgendler merged 2 commits intoAug 26, 2025
Conversation
Collaborator
|
Removing the rexml entry altogether allows it to go to the latest with no issues. |
Contributor
Author
Should I point the PR to latest branch rather? Apologies, I got a bit confused with your comment. |
Collaborator
|
Sorry for that. Remove the entry and keep it pointed to sequoia. Thanks. |
Contributor
Author
Done |
brodjieski
requested changes
Jul 15, 2025
Collaborator
brodjieski
left a comment
There was a problem hiding this comment.
go ahead and remove the line for the rexml gem, it will get included as a dependency for asciidoctor-pdf (actually a dependency of prawn-svg, which is a dependency of asciidoctor-pdf).
I've tested the process when we don't even include the rexml in the Gemfile and should be OK to remove.
Updated pull request. Removed rexml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rexml version used in Gemfile is out of date and has security vulnerabilities which should be patched. Please see the dependabot findings when I ran it on my forked repo after upgrading the version number to 3.3.9