Consolidated profile#542
Conversation
|
|
||
| consolidated_plist_file_path = os.path.join(settings_plist_output_path, f"{baseline_name}.plist") | ||
| with open(consolidated_plist_file_path, "wb") as consolidated_plist_file: | ||
| consolidated_profile.finalizeAndSavePlist(consolidated_plist_file) |
There was a problem hiding this comment.
This doesn't seem to work: It doesn't write a consolidated .plist file but seems to rewrite the previously written domain specific .plist files.
There was a problem hiding this comment.
The finalizeAndSavePlist function pulls out all of the settings from a configuration profile and writes the individual .plists for each preference domain. While the consolidated mobileconfig makes sense to me, I'm not sure a consolidated .plist file would be useful. Since .plists are applied to specific domains, having all of the domains in a single plist couldn't really be used.
There was a problem hiding this comment.
I've removed these lines.
I have to admit that I'm still confused about the purpose of the domain specific plist files: The keys and values are already part of the corresponding mobileconfig files and the generated comliance script accesses only the .audit.plist file.
There was a problem hiding this comment.
The .plist files are generated for those that want to use something like the "Application and Custom Settings" payload in Jamf Pro. This let's you input .plist files into a configuration profile for Jamf Pro to deploy. Other MDMs also have the ability to deploy these managed preferences outside of their "supported" deployments.
The project outputs both to offer that flexibility.
There was a problem hiding this comment.
Reviewing the changes... the default_audit_plist function is no longer generating the default audit plist file that is used as an example for exemptions. I think it's due to the changes around line 880 or so. Is there a reason why you wanted to make those changes?
There was a problem hiding this comment.
Actually, my mistake, i was looking at the incorrect output folder. You can ignore my last question.
brodjieski
left a comment
There was a problem hiding this comment.
Rather than this being default behavior when generating profiles, can you add a new command line argument -P that will handle this generation?
|
Of course. Do you prefer |
I think we would want it as an additional option. So, for example, if someone only had |
|
I didn't manage to finish the change this week; I'll do it next week. |
77948dd to
d8f2ecc
Compare
closes #536