Fix: return 405 on POST request for plain pages in dev (#38863)#94529
Open
EduardF1 wants to merge 1 commit into
Open
Fix: return 405 on POST request for plain pages in dev (#38863)#94529EduardF1 wants to merge 1 commit into
EduardF1 wants to merge 1 commit into
Conversation
| (typeof components.Component === 'string' || isSSG) | ||
| (typeof components.Component === 'string' || | ||
| isSSG || | ||
| (!isAppPath && !hasServerProps)) |
Contributor
There was a problem hiding this comment.
New 405 condition (!isAppPath && !hasServerProps) incorrectly rejects non-GET/HEAD requests for Pages-Router pages that use getInitialProps, returning 405 where they previously rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38863. The 405 check in base-server.ts relied on typeof components.Component === 'string', which is only true for pre-rendered HTML pages in production. In dev mode, pages are compiled as JS modules, so the check never triggered for plain pages. This expands the condition to also catch Pages Router pages without getServerSideProps in dev mode (!isAppPath && !hasServerProps).