[pull] master from scrapinghub:master#88
Merged
Conversation
* new USE_GIVEN_LANGUAGE_ORDER setting * remove use_given_order param and use USE_GIVEN_LANGUAGE_ORDER setting in DateDataParser * docs for USE_GIVEN_LANGUAGE_ORDER * fix date order parsing with empty languages or locales * added empty locales case in docs * removed use_given_order tests from init date tests * added USE_GIVEN_LANGUAGE_ORDER tests * flake8 fix for tests and conf.py * add mandatory locales or languages when USE_GIVEN_LANGUAGES is set and fixed tests * Finalize USE_GIVEN_LANGUAGE_ORDER: keep use_given_order, no-op on empty (#770) Reconcile the rebased work onto current master with the agreed design: - Keep the public ``use_given_order`` constructor argument (non-breaking); the new ``USE_GIVEN_LANGUAGE_ORDER`` setting is OR-ed with it rather than replacing it, and also reaches the top-level ``dateparser.parse()``. - When the setting is True but no languages/locales are given, it is a no-op (fall back to the default order) instead of raising. - Register ``USE_GIVEN_LANGUAGE_ORDER`` in ``check_settings`` so it is a valid setting, document it under "Language Order" in docs/settings.rst, and add settings-validation and parsing tests. - Revert the unneeded loader change: DateDataParser already normalizes an empty languages list to None. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Serhii A <aserhii@protonmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )