Skip to content

[pull] master from scrapinghub:master#88

Merged
pull[bot] merged 2 commits into
zanachka:masterfrom
scrapinghub:master
Jun 8, 2026
Merged

[pull] master from scrapinghub:master#88
pull[bot] merged 2 commits into
zanachka:masterfrom
scrapinghub:master

Conversation

@pull

@pull pull Bot commented Jun 8, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

dariuschira and others added 2 commits June 8, 2026 10:33
* new USE_GIVEN_LANGUAGE_ORDER setting

* remove use_given_order param and use USE_GIVEN_LANGUAGE_ORDER setting in DateDataParser

* docs for USE_GIVEN_LANGUAGE_ORDER

* fix date order parsing with empty languages or locales

* added empty locales case in docs

* removed use_given_order tests from init date tests

* added USE_GIVEN_LANGUAGE_ORDER tests

* flake8 fix for tests and conf.py

* add mandatory locales or languages when USE_GIVEN_LANGUAGES is set and fixed tests

* Finalize USE_GIVEN_LANGUAGE_ORDER: keep use_given_order, no-op on empty (#770)

Reconcile the rebased work onto current master with the agreed design:

- Keep the public ``use_given_order`` constructor argument (non-breaking);
  the new ``USE_GIVEN_LANGUAGE_ORDER`` setting is OR-ed with it rather than
  replacing it, and also reaches the top-level ``dateparser.parse()``.
- When the setting is True but no languages/locales are given, it is a no-op
  (fall back to the default order) instead of raising.
- Register ``USE_GIVEN_LANGUAGE_ORDER`` in ``check_settings`` so it is a valid
  setting, document it under "Language Order" in docs/settings.rst, and add
  settings-validation and parsing tests.
- Revert the unneeded loader change: DateDataParser already normalizes an
  empty languages list to None.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Serhii A <aserhii@protonmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@pull pull Bot locked and limited conversation to collaborators Jun 8, 2026
@pull pull Bot added the ⤵️ pull label Jun 8, 2026
@pull pull Bot merged commit 5c6d97f into zanachka:master Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants