Add Event::Minimized and Event::Maximized for win32, X11, and MacOS platforms#3650
Add Event::Minimized and Event::Maximized for win32, X11, and MacOS platforms#3650raustin9 wants to merge 15 commits into
Conversation
|
|
||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Was not sure if the similar behavior of isMinimized and isMaximized should be abstracted into a separate function to check values of atoms
|
Could you also add them to the events_example for easier testing please? |
|
How do you determine when a window is restored, i.e. un-minimized or un-maximized? |
On win32 I check for the SIZE_RESTORED case. Should the Maximized and Minimized events hold a value like this struct Minimized
{
bool restored;
};that can be checked? |
Done! |
…austin9/SFML into feature/window-min-max-events
|
I plan to test this on mac at some point, but curious in your tests if you tested what happens when you use the system spaces fullscreen (pushing the fullscreen titlebar button, Currently that is a separate fullscreen mode to the one used by SFML code which #3662 aims to address |
Description
Add events to trigger on window minimization and maximization for Windows, MacOS, and Linux platforms.
Event::Minimize triggers when the window is minimized, and Event::Maximized triggers on window maximization.
This PR is related to the issue #3294
Tasks
How to test this PR?
Open a window on the supported platforms, and detect whether the minimized and maximized events are triggering. This is easiest done through an example similar to the one below. The minimize event should trigger when the minimize button is clicked on the window, and the maximized event should trigger when the maximize button is clicked.
Minimal example: