Allow more granular selection of system dependencies (inc. SheenBidi)#3723
Open
solbjorn wants to merge 1 commit into
Open
Allow more granular selection of system dependencies (inc. SheenBidi)#3723solbjorn wants to merge 1 commit into
solbjorn wants to merge 1 commit into
Conversation
"System deps" might be used not only when the corresponding packages are installed by the OS package manager, but also when compiling them separately. In either case, it would be useful to allow selecting which system/external dependencies shoud be used and which should be built within SFML more granularly. Add the corresponding options. Freetype and Harfbuzz are combined into one option due to their circular dependencies, same with FLAC and Vorbis, and MbedTLS and libssh. Allow using external SheenBidi. The default behaves just like before the change, and the global `SFML_USE_SYSTEM_DEPS` switch is still here. Signed-off-by: Alexander Lobakin <alobakin@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"System deps" might be used not only when the corresponding packages are installed by the OS package manager, but also when compiling them separately. In either case, it would be useful to allow selecting which system/external dependencies shoud be used and which should be built within SFML more granularly.
Add the corresponding options. Freetype and Harfbuzz are combined into one option due to their circular dependencies, same with FLAC and Vorbis, and MbedTLS and libssh. Allow using external SheenBidi. The default behaves just like before the change, and the global
SFML_USE_SYSTEM_DEPSswitch is still here.Tasks
How to test this PR?
Compile test on different OSes and different combinations of the system dependencies options.