fix(routing): preserve SSE stream_item_type through include_router#15445
Open
onthebed wants to merge 2 commits into
Open
fix(routing): preserve SSE stream_item_type through include_router#15445onthebed wants to merge 2 commits into
onthebed wants to merge 2 commits into
Conversation
Member
|
This is basically the same approach as in #15426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include_routerrecreates SSE routes withresponse_model=None, so the merged route dropsstream_item_typeand loses the item schema.Copied the streaming metadata onto the recreated route and rebuilt its handler so OpenAPI and runtime serialization keep seeing the field.
Added a regression test for an included SSE route that checks the merged route metadata and OpenAPI schema.
Fixes #15401