Preserve null values in user-provided OpenAPI example/examples#15646
Open
AshNicolus wants to merge 2 commits into
Open
Preserve null values in user-provided OpenAPI example/examples#15646AshNicolus wants to merge 2 commits into
null values in user-provided OpenAPI example/examples#15646AshNicolus wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported across #8401, #12048, and #5559 (29+ community votes total): user-provided
nullvalues insideexampleandexamplesare silently dropped from the generated OpenAPI document, even whennullis a legitimate documented value (e.g. a nullable required field in a response example).The root cause is the final pass in
get_openapi: