This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Replace assert.equal with assert.strictEqual#562
Merged
mayurkale22 merged 2 commits intoMay 29, 2019
Conversation
draffensperger
approved these changes
May 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
==========================================
- Coverage 95.3% 95.27% -0.03%
==========================================
Files 148 148
Lines 10589 10550 -39
Branches 744 742 -2
==========================================
- Hits 10092 10052 -40
- Misses 497 498 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert.equal()is deprecated since node v10.There will be follow-up PRs,
assert.notEqual withassert.notstrictEqualassert.deepEqualwithassert.deepStrictEqualassert.notDeepEqualwithassert.notStrictEqual