This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Replace assert.deepEqual with assert.deepStrictEqual#563
Merged
mayurkale22 merged 1 commit intoMay 31, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
==========================================
- Coverage 95.3% 95.26% -0.04%
==========================================
Files 148 147 -1
Lines 10590 10548 -42
Branches 745 746 +1
==========================================
- Hits 10093 10049 -44
- Misses 497 499 +2
Continue to review full report at Codecov.
|
Member
Author
|
@draffensperger Please review once you have time. |
draffensperger
approved these changes
May 31, 2019
draffensperger
left a comment
Contributor
There was a problem hiding this comment.
I think I must have looked at this and thought I reviewed but didn't finish it!
Member
Author
Np, thanks for the reviews. This PR is important in order to adopt gts v1 (#506) and fix long pending vulnerabilities #506 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #562