dev: Expose serial terminal listen address to Python#3205
Open
OmeletWithoutEgg wants to merge 1 commit into
Open
dev: Expose serial terminal listen address to Python#3205OmeletWithoutEgg wants to merge 1 commit into
OmeletWithoutEgg wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a C++/Python-accessible accessor to retrieve the current serial terminal listener output, enabling external inspection/debugging of terminal capture state.
Changes:
- Added
Terminal::getListenerOutput()to surface listener output as astd::string. - Implemented the new method by streaming listener output into a
std::stringstream. - Exposed the method on the Python
TerminalSimObject via@cxxMethod.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/dev/serial/terminal.hh | Declares new getListenerOutput() API on Terminal. |
| src/dev/serial/terminal.cc | Implements getListenerOutput() by collecting listener output into a string. |
| src/dev/serial/Terminal.py | Exposes getListenerOutput() to Python via cxxMethod. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+362
to
+364
| if (!listener) { | ||
| return "not listening"; | ||
| } |
Comment on lines
+366
to
+368
| std::stringstream ss; | ||
| listener->output(ss); | ||
| return ss.str(); |
| /////////////////////// | ||
| // Terminal Interface | ||
|
|
||
| std::string getListenerOutput() const; |
This patch adds a `getListenerOutput()` interface to the Terminal object to retrieve the actual bound address after potential runtime increments. This allows external tools to accurately detect serial terminals regardless of TCP or UNIX socket usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a
getListenerOutput()interface to the Terminal object to retrieve the actual bound address after potential runtime increments.This allows external tools to accurately detect serial terminals regardless of TCP or UNIX socket usage.